You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/09/02 02:51:00 UTC

[jira] [Commented] (PHOENIX-4152) Don't swallow or wrap exception in BaseQueryIT constructor

    [ https://issues.apache.org/jira/browse/PHOENIX-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151384#comment-16151384 ] 

Hadoop QA commented on PHOENIX-4152:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12885044/PHOENIX-4152.patch
  against master branch at commit 1aabbfa0d04261d1cebba845deaebf4c4048ae62.
  ATTACHMENT ID: 12885044

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 62 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    public AggregateQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {
+    public CaseStatementIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {
+    public CastAndCoerceIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {
+    public ClientTimeArithmeticQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {
+    public MutableQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {
+    public PointInTimeQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws Exception {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OnDuplicateKeyIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1351//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1351//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1351//console

This message is automatically generated.

> Don't swallow or wrap exception in BaseQueryIT constructor
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4152
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4152
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4152.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)