You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:52:35 UTC
[GitHub] [commons-io] liran2000 opened a new pull request #245: IO-724 deleteDirectory exception javadoc update
liran2000 opened a new pull request #245:
URL: https://github.com/apache/commons-io/pull/245
FileUtils.deleteDirectory javadoc is inaccurate for nonexistent directory.
Change for returned exception javadoc, as the conditions at the method implementation do not match the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860819880
[](https://coveralls.io/builds/40565329)
Coverage remained the same at 89.25% when pulling **4cdb88caaa0b05517ba84d0b2686c73719717ca0 on liran2000:IO-724-javadoc** into **ff0237315321bf9e01d0df3aaf1b4e6a4d3b1618 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] liran2000 edited a comment on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
liran2000 edited a comment on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860778084
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to suggest Nullable or NotNull.
>
The most important here is to remove the "IllegalArgumentException" if directory does not exist from the javadoc, which does not match the implementation condition: if (!directory.exists()) { return;}
Regarding Nullable/NotNull, got it, removed this addition for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-861440160
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to suggest Nullable or NotNull.
>
> How's it going @garydgregory ?
Fixing Javadoc here is good. JSR305/8 is a different story, which are doing for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843
> > @XenoAmess @garydgregory thank you, can you then please review and merge this PR ?
>
> I should be able to look at this later today, AFK ATM.
@garydgregory thanks, will wait for your review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory edited a comment on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-861440160
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to suggest Nullable or NotNull.
>
> How's it going @garydgregory ?
Fixing Javadoc here is good. JSR305/8 is a different story, which we are not doing for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] XenoAmess commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860728365
Thinng about this will be better when after we apply JSR305
If my memory be correct, there be a branch adding these annotations to suggest Nullable or NotNull.
How's it going @garydgregory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls edited a comment on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860819880
[](https://coveralls.io/builds/40585062)
Coverage remained the same at 89.25% when pulling **eb4d3c87957b106457b32fc1c4d5a57d33e429ba on liran2000:IO-724-javadoc** into **ff0237315321bf9e01d0df3aaf1b4e6a4d3b1618 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-865148843
> > @XenoAmess @garydgregory thank you, can you then please review and merge this PR ?
>
> I should be able to look at this later today, AFK ATM.
@garydgregory thanks, will wait for your review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-861468125
> @XenoAmess @garydgregory thank you, can you then please review and merge this PR ?
I should be able to look at this later today, AFK ATM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #245:
URL: https://github.com/apache/commons-io/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860778084
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to suggest Nullable or NotNull.
>
The most important here is to remove the "IllegalArgumentException" if directory does not exist or from the javadoc, which does not match the implementation condition: if (!directory.exists()) { return;}
Regarding Nullable/NotNull, got it, removed this addition for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] liran2000 commented on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
liran2000 commented on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-861453090
@XenoAmess @garydgregory thank you, can you then please review and merge this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls edited a comment on pull request #245: IO-724 deleteDirectory exception javadoc inaccurate update
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860819880
[](https://coveralls.io/builds/40615688)
Coverage remained the same at 89.25% when pulling **eb4d3c87957b106457b32fc1c4d5a57d33e429ba on liran2000:IO-724-javadoc** into **ff0237315321bf9e01d0df3aaf1b4e6a4d3b1618 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org