You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "priyeshkaratha (via GitHub)" <gi...@apache.org> on 2026/07/14 18:14:23 UTC
[PR] HDDS-13774. [Recon] Consolidate NSSummary endpoint tests into one suite [ozone]
priyeshkaratha opened a new pull request, #10769:
URL: https://github.com/apache/ozone/pull/10769
## What changes were proposed in this pull request?
The NSSummary REST API had three near-duplicate test classes TestNSSummaryEndpointWith{FSO,Legacy,OBSAndLegacy} (~4,500 lines). This replaces them with a single @ParameterizedClass suite (TestNSSummaryEndpoint) driven by per-layout scenario objects, sharing all constants, fixtures, and assertions.
- Duplication: FSO and Legacy were ~95% identical; all three repeated the mock SCM, replica generation, and populate logic.
- Weak replication coverage: the three Ratis tests asserted getReplicatedSize(response.getSize()) == response.getSizeWithReplica() — both sides from the endpoint's own output, so they passed regardless of correctness. Keys were written with factor ONE, so sizeWithReplica collapsed to the raw size despite elaborate multi-block/container setup.
Multi-block keys now use genuine RATIS/THREE replication; replication tests assert sizeWithReplica (3×) and raw size against independent constants.
## What is the link to the Apache JIRA
HDDS-13774
## How was this patch tested?
TestNSSummaryEndpoint: 117 run, 0 failures. checkstyle.sh and rat.sh clean
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13774. [Recon] Consolidate NSSummary endpoint tests into one suite [ozone]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha merged PR #10769:
URL: https://github.com/apache/ozone/pull/10769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13774. [Recon] Consolidate NSSummary endpoint tests into one suite [ozone]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on PR #10769:
URL: https://github.com/apache/ozone/pull/10769#issuecomment-5048666112
Thanks @devmadhuu for reviewing the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org