[GitHub] [hadoop-ozone] adoroszlai commented on issue #446: HDDS-2859. Hugo error should be propagated to build

[GitBox <gi...@apache.org>]

adoroszlai commented on issue #446: HDDS-2859. Hugo error should be propagated to build
URL: https://github.com/apache/hadoop-ozone/pull/446#issuecomment-575255393
 
 
   Thanks @xiaoyuyao for taking a look at this. 
   
   > so the main change is contained in the apache/ozone-build image itself?
   
   No, the fix itself is really in 4c70b7ce0c1daa004a29ce6a84a92287767c2c6b.  `set -e` makes bash exit the script on any error, and thus propagate the result of `hugo` in case it fails.  Without this change the script ignores the error and exits with the result of the last command: `cd -` (which is usually success).
   
   After testing the fix locally and pushing to my fork, I realized that the image used by CI checks does not even have Hugo installed.  (Which the script treats as OK, to avoid forcing developers to install it for Maven to work).  So the image change (apache/hadoop-docker-ozone#10) was only necessary to pre-install Hugo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org