You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "malliaridis (via GitHub)" <gi...@apache.org> on 2024/10/22 14:15:20 UTC
[PR] SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages [solr]
malliaridis opened a new pull request, #2789:
URL: https://github.com/apache/solr/pull/2789
https://issues.apache.org/jira/browse/SOLR-17467
# Description
The Windows start script on 9x behaves differently than on main / 10.0, and fails with the message "mode. was unexpected at this time.". This mesage is coming from the deprecation warnings.
# Solution
The fix moves the deprecation warnings to the dedicated mode setter functions and uses `echo` instead of `@echo`, which probably caused the execution error.
Additionally, this commit adds support for the `--user-managed` mode that allows the user to suppress the deprecation warning by being explicit about the current mode.
# Tests
Not tests were altered.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages [solr]
Posted by "malliaridis (via GitHub)" <gi...@apache.org>.
malliaridis commented on PR #2789:
URL: https://github.com/apache/solr/pull/2789#issuecomment-2429749826
Good point, I only checked the Windows script because of the bug, but I will have a look about the --user-managed option support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages [solr]
Posted by "malliaridis (via GitHub)" <gi...@apache.org>.
malliaridis commented on PR #2789:
URL: https://github.com/apache/solr/pull/2789#issuecomment-2432320604
I've now updated the behavior for `bin/solr` as well, so the script prints messages for `--cloud/-c` and when not using `--user-managed` (and falls back to default / user-managed mode). That way the user is notified when he uses a combination that will either no longer be supported (usage of `-c`) or the default behavior changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages [solr]
Posted by "malliaridis (via GitHub)" <gi...@apache.org>.
malliaridis merged PR #2789:
URL: https://github.com/apache/solr/pull/2789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2789:
URL: https://github.com/apache/solr/pull/2789#issuecomment-2431216346
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org