[GitHub] [storm] srdo commented on a change in pull request #3062: STORM-3447: jms: fix all checkstyle warnings

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #3062: STORM-3447: jms: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3062#discussion_r300118016
 
 

 ##########
 File path: external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsMessageID.java
 ##########
 @@ -14,20 +14,21 @@
 
 import java.io.Serializable;
 
+@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
 public class JmsMessageID implements Comparable<JmsMessageID>, Serializable {
 
-    private String jmsID;
+    private String jmsId;
 
     private Long sequence;
 
-    public JmsMessageID(long sequence, String jmsID) {
-        this.jmsID = jmsID;
+    public JmsMessageID(long sequence, String jmsId) {
+        this.jmsId = jmsId;
         this.sequence = sequence;
     }
 
-
-    public String getJmsID() {
-        return this.jmsID;
+    @SuppressWarnings("checkstyle:AbbreviationAsWordInName")
+    public String getJmsId() {
 
 Review comment:
   I don't think we should rename this, unless users can't directly access this class?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services