You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/05/13 21:40:17 UTC

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #446: HTTPCLIENT-2273: Enhance "no-cache" directive handling

arturobernalg commented on code in PR #446:
URL: https://github.com/apache/httpcomponents-client/pull/446#discussion_r1193043166


##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheControlHeaderParser.java:
##########
@@ -162,6 +169,19 @@ public final CacheControl parse(final Header header) {
                 mustRevalidate = true;
             } else if (name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_NO_CACHE)) {
                 noCache = true;
+                if (value != null) {
+                    final Tokenizer.Cursor valueCursor = new Tokenizer.Cursor(cursor.getPos() - value.length() -1, buffer.length());

Review Comment:
   I made some changes to avoid creating an additional Tokenizer.Cursor, but I'm not completely certain if it's what you're looking for..
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org