[jira] [Commented] (AMBARI-16451) Takeover script configs results in conflict message that look wrong

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280315#comment-15280315 ] 

Hadoop QA commented on AMBARI-16451:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12803431/AMBARI-16451.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6821//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6821//console

This message is automatically generated.

> Takeover script configs results in conflict message that look wrong
> -------------------------------------------------------------------
>
>                 Key: AMBARI-16451
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16451
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16451.patch
>
>
> Attaching the zip file with configs and conflicts.
>   * The conflicting configs seem to have a lot of duplicate info  
> mapred-site :: dfs.datanode.du.reserved
>   * Unable to handle empty config files:  
> Had to hand edit and add try / catch at :
> > yaml.load(file).iteritems()
> > parsed_configurations_from_path, parsed_properties_attributes =
> parser.read_data_to_map(path)
>     
>     
>     
>     Traceback (most recent call last):
>       File "./takeover_config_merge.py", line 393, in <module>
>         sys.exit(main())
>       File "./takeover_config_merge.py", line 389, in main
>         return configMerge.perform_merge()
>       File "./takeover_config_merge.py", line 279, in perform_merge
>         parsed_configurations_from_path, parsed_properties_attributes = parser.read_data_to_map(path)
>       File "./takeover_config_merge.py", line 86, in read_data_to_map
>         for name, value in yaml.load(file).iteritems():
>     AttributeError: 'NoneType' object has no attribute 'iteritems'
>     
> _Instruction_
>     
>     
>     
>     ./takeover_config_merge.py -o blueprint -i files
>     



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)