You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/27 03:02:08 UTC
[GitHub] [spark] Ngone51 opened a new pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Ngone51 opened a new pull request #32356:
URL: https://github.com/apache/spark/pull/32356
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`failureMessage` is already formatted, but `replaceAll("\n", " ")` destroyed the format. This PR fixed it.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The formatted error message is easier to read and debug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, users see the clear error message of stage failure.
Before:
After:
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manually tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-828066481
Will leave it to you @attilapiros then :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827304483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827288510
Yes, the screenshot is from a test. It's for convenient purpose. But the stage failure is shown to users directly, right? So I consider it a user-facing change.
Attach UI changes sounds like better idea, which is surely a user-facing change. I'll try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 edited a comment on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 edited a comment on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827294571
@attilapiros I have done the experiment on UI. And it turns out that the format in UI is always correct. That's because we passed the formatted `failureMessage` to UI directly without any change. You could check the related code there:
https://github.com/apache/spark/blob/38ef4771d447f6135382ee2767b3f32b96cb1b0e/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827654570
I leave it here for 2 more days to let the others to review it and if no issue comes up I'll merge it (assuming it's still passing CI and no review is in progress).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827348078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827285607
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827304500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42497/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827287106
@Ngone51 the images you attached to the PR description are the logs of a running test?
If yes that would be not a user-facing change but a developer-facing one :)
But I think these messages are landing on the UI and those should be attached to the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827328738
The description would be perfect with the UI screenshot and it would be so good to take a look how the message is actually rendered on UI.
@Ngone51 So I would like to kindly ask you to make those screenshots (before and after) by for example doing a temporarily code change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827278383
cc @mridulm @tgravescs @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827343287
**[Test build #137977 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137977/testReport)** for PR 32356 at commit [`0896255`](https://github.com/apache/spark/commit/0896255f43c622e096cab6b0eee5bc4f715abc40).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827651427
changes look fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827385259
> As users cannot see / should not care about test logs.
@attilapiros It's not only able to see in the test, but also in a user application. Here, I used the test as an example to show the difference.
And probably it's my bad not to mention in advance: I changed a little bit in the test in order to show the error message (it's captured previously). So, I'm not fixing the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827372780
@Ngone51 Oh I see. Then please update the "Does this PR introduce any user-facing change?" section to "No."
As users cannot see / should not care about test logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros edited a comment on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros edited a comment on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827284117
There is another case of using `replaceAll` on the message:
https://github.com/apache/spark/blob/78caf0a53e60d81e6211faadfc45fede5ef9c941/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1957
What about fixing that one too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827284117
There is another case of using `replaceAll` on the message:
https://github.com/apache/spark/blob/78caf0a53e60d81e6211faadfc45fede5ef9c941/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1957
What about fixing that one, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827304500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42497/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827368144
@attilapiros I'm not sure if I misunderstood your request. I have done the UI experiment (https://github.com/apache/spark/pull/32356#issuecomment-827294571) and it turns out UI isn't affected. So I think I don't have to add the UI screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827394368
I think I see what you mean and why I am confused: I know you are not fixing a test but as you used test logs and said the UI is not affected I thought it has only relevance for test execution. But of course this fixes the application log as well.
So let's mention "application log" in the PR description to help the others who are reading the commit message after the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827287450
**[Test build #137977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137977/testReport)** for PR 32356 at commit [`0896255`](https://github.com/apache/spark/commit/0896255f43c622e096cab6b0eee5bc4f715abc40).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-829332961
thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-828164331
@HyukjinKwon I am keeping my promise made here: https://github.com/apache/spark/pull/32180#issuecomment-820454967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros closed pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros closed pull request #32356:
URL: https://github.com/apache/spark/pull/32356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827348078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #32356:
URL: https://github.com/apache/spark/pull/32356#discussion_r620826226
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1951,11 +1950,8 @@ private[spark] class DAGScheduler(
"Barrier stage will not retry stage due to testing config. Most recent failure " +
s"reason: $message"
} else {
- s"""$failedStage (${failedStage.name})
- |has failed the maximum allowable number of
- |times: $maxConsecutiveStageAttempts.
- |Most recent failure reason: $message
- """.stripMargin.replaceAll("\n", " ")
+ s"$failedStage (${failedStage.name}) has failed the maximum allowable number of " +
+ s"times: $maxConsecutiveStageAttempts. Most recent failure reason: $message"
Review comment:
Note that we don't append `\n` for this "Most recent failure reason" because `message` already contains it:
```scala
val message = s"Stage failed because barrier task $task finished unsuccessfully.\n" +
failure.toErrorString
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827294571
@attilapiros I have done the experiment on UI. And it turns out that the format in UI is always correct. That's because we passed the formatted `failureMessage` to UI directly without any change. See:
https://github.com/apache/spark/blob/38ef4771d447f6135382ee2767b3f32b96cb1b0e/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827373439
In the title you can add [TESTS].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32356: [SPARK-35234][CORE] Reserve the format of stage failureMessage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32356:
URL: https://github.com/apache/spark/pull/32356#issuecomment-827287450
**[Test build #137977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137977/testReport)** for PR 32356 at commit [`0896255`](https://github.com/apache/spark/commit/0896255f43c622e096cab6b0eee5bc4f715abc40).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org