You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2020/09/21 06:05:01 UTC
Review Request 72889: RANGER-3005: repoType and repo values does not
set when Audit to Elasticsearch is enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72889/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Dhaval Shah, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3005
https://issues.apache.org/jira/browse/RANGER-3005
Repository: ranger
Description
-------
When Audit to Elasticsearch is enabled then in Audit => Access tab "repo/repoType" column is empty.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java f28eb248f
Diff: https://reviews.apache.org/r/72889/diff/1/
Testing
-------
Already using in Production environment.
Thanks,
bhavik patel
Re: Review Request 72889: RANGER-3005: repoType and repo values does
not set when Audit to Elasticsearch is enabled
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72889/#review221908
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 194 (patched)
<https://reviews.apache.org/r/72889/#comment310959>
Please add null and empty check for xxService.getDisplayName().
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 239 (patched)
<https://reviews.apache.org/r/72889/#comment310960>
Please add null and empty check for xServiceDef.getDisplayName()
- Dhaval Shah
On Sept. 21, 2020, 6:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72889/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 6:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dhaval Shah, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3005
> https://issues.apache.org/jira/browse/RANGER-3005
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When Audit to Elasticsearch is enabled then in Audit => Access tab "repo/repoType" column is empty.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java f28eb248f
>
>
> Diff: https://reviews.apache.org/r/72889/diff/1/
>
>
> Testing
> -------
>
> Already using in Production environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 72889: RANGER-3005: repoType and repo values does
not set when Audit to Elasticsearch is enabled
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72889/#review221965
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Shah
On Sept. 21, 2020, 6:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72889/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 6:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dhaval Shah, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3005
> https://issues.apache.org/jira/browse/RANGER-3005
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When Audit to Elasticsearch is enabled then in Audit => Access tab "repo/repoType" column is empty.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java f28eb248f
>
>
> Diff: https://reviews.apache.org/r/72889/diff/1/
>
>
> Testing
> -------
>
> Already using in Production environment.
>
>
> Thanks,
>
> bhavik patel
>
>