[GitHub] [spark] MaxGekk commented on a diff in pull request #42846: [SPARK-43252][SQL] Replace the error class `_LEGACY_ERROR_TEMP_2016` with an internal error

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #42846:
URL: https://github.com/apache/spark/pull/42846#discussion_r1321059068


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala:
##########
@@ -117,7 +117,7 @@ class CodeBlockSuite extends SparkFunSuite {
 
   test("Throws exception when interpolating unexpected object in code block") {
     val obj = Tuple2(1, 1)
-    val e = intercept[IllegalArgumentException] {
+    val e = intercept[SparkException] {
       code"$obj"
     }
     assert(e.getMessage().contains(s"Can not interpolate ${obj.getClass.getName}"))

Review Comment:
   As you are here, please, use `checkError` to check the error class and other parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org