You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/02/13 16:18:17 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
xiaoxiang781216 opened a new pull request, #8523:
URL: https://github.com/apache/nuttx/pull/8523
## Summary
correct SIZE_MAX and SSIZE_MAX/SSIZE_MIN definition
## Impact
SSIZE_MAX and SSIZE_MIN
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8523:
URL: https://github.com/apache/nuttx/pull/8523#discussion_r1107227268
##########
include/limits.h:
##########
@@ -136,11 +136,11 @@
#else /* CONFIG_SMALL_MEMORY */
-#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */
+#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */
#define _POSIX_SIZE_MIN 0
-#define _POSIX_SSIZE_MAX 2147483647L /* See sys/types.h */
-#define _POSIX_SSIZE_MIN -2147483648L
+#define _POSIX_SSIZE_MAX LONG_MAX /* See sys/types.h */
Review Comment:
Done.
##########
include/limits.h:
##########
@@ -136,11 +136,11 @@
#else /* CONFIG_SMALL_MEMORY */
-#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */
+#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #8523:
URL: https://github.com/apache/nuttx/pull/8523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8523:
URL: https://github.com/apache/nuttx/pull/8523#discussion_r1105651098
##########
include/limits.h:
##########
@@ -136,11 +136,11 @@
#else /* CONFIG_SMALL_MEMORY */
-#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */
+#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */
Review Comment:
```suggestion
#define _POSIX_SIZE_MAX ULONG_MAX
```
##########
include/limits.h:
##########
@@ -136,11 +136,11 @@
#else /* CONFIG_SMALL_MEMORY */
-#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */
+#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */
#define _POSIX_SIZE_MIN 0
-#define _POSIX_SSIZE_MAX 2147483647L /* See sys/types.h */
-#define _POSIX_SSIZE_MIN -2147483648L
+#define _POSIX_SSIZE_MAX LONG_MAX /* See sys/types.h */
Review Comment:
```suggestion
#define _POSIX_SSIZE_MAX LONG_MAX
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org