[GitHub] [arrow-datafusion] mslapek commented on issue #4628: Remove Arc from LogicalPlan

["mslapek (via GitHub)" <gi...@apache.org>]

mslapek commented on issue #4628:
URL: https://github.com/apache/arrow-datafusion/issues/4628#issuecomment-1454773148

   How would `OptimizerRule` look after the change?
   
   Currently we have:
   
   ```rust
   /// Try and rewrite `plan` to an optimized form, returning None if the plan cannot be
   /// optimized by this rule.
   fn try_optimize(
       &self,
       plan: &LogicalPlan,
       config: &dyn OptimizerConfig,
   ) -> Result<Option<LogicalPlan>>;
   ```
   
   With the current `try_optimize` signature, lack of `Arc<LogicalPlan>` would require to **clone whole non-optimised subbranches**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org