[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24268: [SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24268: [SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly
URL: https://github.com/apache/spark/pull/24268#discussion_r271131288
 
 

 ##########
 File path: python/pyspark/testing/utils.py
 ##########
 @@ -103,7 +103,7 @@ def close(self):
         pass
 
 
-def search_jar(project_relative_path, jar_name_prefix):
+def search_jar(project_relative_path, sbt_jar_name_prefix, mvn_jar_name_prefix):
 
 Review comment:
   Hi, @HyukjinKwon . Since SPARK-26856 used this function for `spark-avro_2.12-3.0.0-SNAPSHOT` which is identical for both `sbt` and `mvn`. Inevitably, I split the parameters. How do you think about this approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org