You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/05/19 22:15:18 UTC

[GitHub] [avro] maccamlc commented on a change in pull request #883: AVRO-2836 Generated java includes logical type conversions

maccamlc commented on a change in pull request #883:
URL: https://github.com/apache/avro/pull/883#discussion_r427631503



##########
File path: lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
##########
@@ -328,6 +328,11 @@ private void getClassNamesOfPrimitiveFields(Schema schema, Set<String> result, S
       break;
     case ENUM:
     case FIXED:

Review comment:
       Thanks for the reply @RyanSkraba .
   
   This was actually done on purpose (ie. Enum and Fixed to check for logical types) as I initially thought to write a test using a custom enum conversion and logical type, that failed, but I feel is made possible and tested through https://github.com/apache/avro/pull/885/files#diff-a675c373b970779aafefc7cb7adf572c (where that PR is also based on this work).
   
   However, if Enum should not actually be used in that way, will definitely add a break here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org