You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/15 17:00:22 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #7698: Second order gradient and Subgraph execution
eric-haibin-lin commented on a change in pull request #7698: Second order gradient and Subgraph execution
URL: https://github.com/apache/incubator-mxnet/pull/7698#discussion_r139200011
##########
File path: src/operator/tensor/elemwise_binary_op_basic.cu
##########
@@ -36,21 +36,21 @@ NNVM_REGISTER_OP(_backward_add)
ElemwiseBinaryOp::BackwardUseNoneWithHalf2<gpu, mshadow_op::identity,
mshadow_op::identity>);
-NNVM_REGISTER_OP(_sub)
+NNVM_REGISTER_OP(elemwise_sub)
.set_attr<FCompute>("FCompute<gpu>", ElemwiseBinaryOp::ComputeWithHalf2<gpu, mshadow::op::minus>);
NNVM_REGISTER_OP(_backward_sub)
.set_attr<FCompute>("FCompute<gpu>", ElemwiseBinaryOp::BackwardUseNoneWithHalf2<
gpu, mshadow_op::identity, mshadow_op::negation>);
-NNVM_REGISTER_OP(_mul)
+NNVM_REGISTER_OP(elemwise_mul)
.set_attr<FCompute>("FCompute<gpu>", ElemwiseBinaryOp::ComputeWithHalf2<gpu, mshadow::op::mul>);
NNVM_REGISTER_OP(_backward_mul)
.set_attr<FCompute>("FCompute<gpu>",
ElemwiseBinaryOp::BackwardUseInWithHalf2<gpu, mshadow_op::right, mshadow_op::left>);
-NNVM_REGISTER_OP(_div)
+NNVM_REGISTER_OP(elemwise_div)
Review comment:
Doesn't this break backward compatibility? @cjolivier01 @piiswrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services