You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/10/07 21:07:58 UTC

[PR] fix(dashboard): reduce excessive padding on FiltersOutOfScopeCollapsible [superset]

sadpandajoe opened a new pull request, #45066:
URL: https://github.com/apache/superset/pull/45066

   ### SUMMARY
   The "Filters out of scope" collapsible section in the dashboard filter bar's vertical panel used antd's default `Collapse` header/content padding, which is larger than the compact spacing the surrounding `FilterControls` sections use (`SectionHeader`/`SectionContent`/`StyledDivider`). Since this collapsible renders directly above the "Display controls" section, the extra bottom padding visibly pushed "Display controls" down.
   
   This trims the header and content-box bottom padding on that one `Collapse` instance to match the filter bar's existing spacing rhythm.
   
   ### BEFORE/AFTER SCREENSHOTS
   N/A — CSS-only spacing fix validated by reading the computed antd token values (ghost `Collapse` header/content padding) and comparing against the sibling `SectionContainer`/`SectionContent` spacing in the same file. I did not have a running Superset instance to capture screenshots.
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard with tabs and native filters where at least one filter is out of scope for the current tab.
   2. Open the vertical filter bar panel.
   3. Confirm the "Filters out of scope (N)" row no longer adds extra space before "Display controls" below it.
   
   Existing tests pass unchanged:
   - `FilterControls.test.tsx` (13 tests)
   - `FiltersDropdownContent.test.tsx` (3 tests)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue
   - [ ] Required feature flags
   - [ ] Changes UI
   - [ ] Includes DB migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): reduce excessive padding on FiltersOutOfScopeCollapsible [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45066:
URL: https://github.com/apache/superset/pull/45066#issuecomment-6047065098

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 82.59%. Comparing base ([`001cb57`](https://app.codecov.io/gh/apache/superset/commit/001cb574e3959d1c0ce58dd5eb83cd3f6627bb12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`21f9348`](https://app.codecov.io/gh/apache/superset/commit/21f934895cf408ca2bca701a4ba820766228e931?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/45066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx](https://app.codecov.io/gh/apache/superset/pull/45066?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FnativeFilters%2FFilterBar%2FFiltersOutOfScopeCollapsible%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNPdXRPZlNjb3BlQ29sbGFwc2libGUvaW5kZXgudHN4) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #45066      +/-   ##
   ==========================================
   - Coverage   82.59%   82.59%   -0.01%     
   ==========================================
     Files        3005     3005              
     Lines      186941   186942       +1     
     Branches    43308    43308              
   ==========================================
     Hits       154399   154399              
   - Misses      29778    29779       +1     
     Partials     2764     2764              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45066/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/45066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.32% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45066?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org