You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2025/04/16 12:29:21 UTC
[PR] server: fix available hypervisors listing for a zone [cloudstack]
shwstppr opened a new pull request, #10738:
URL: https://github.com/apache/cloudstack/pull/10738
### Description
In the absence of a SYSTEM type template for a zone, listing of templates can break.
Behaviour was change in #9840 but it would be better to find available hypervisors using existing hosts.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809614484
> I remember there is a similar method, so looked for it
>
> https://github.com/apache/cloudstack/blob/55c811547a8c516c065c99f4d1ede5f43913c4c1/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java#L168-L178
nice find @weizhouapache , do you mean we should make a template method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2818202848
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2813141380
Thanks @weizhouapache . It seems HostDao and ClusterDao can return different results. Maybe we can have a separate refactor to consolidate this or should I make the change here to user ClusterDao?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2811768894
> I remember there is a similar method, so looked for it
>
> https://github.com/apache/cloudstack/blob/55c811547a8c516c065c99f4d1ede5f43913c4c1/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java#L168-L178
@weizhouapache are you suggesting using ClusterDao method here or in the callers itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#discussion_r2052276509
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -3266,12 +3263,16 @@ public List<HostVO> listAllHostsInAllZonesByType(final Type type) {
@Override
public List<HypervisorType> listAvailHypervisorInZone(final Long zoneId) {
- List<VMTemplateVO> systemVMTemplates = _templateDao.listAllReadySystemVMTemplates(zoneId);
- final Set<HypervisorType> hypervisors = new HashSet<>();
- for (final VMTemplateVO systemVMTemplate : systemVMTemplates) {
- hypervisors.add(systemVMTemplate.getHypervisorType());
+ final SearchCriteria<String> sc = _hypervisorsInDC.create();
+ if (zoneId != null) {
+ sc.setParameters("dataCenter", zoneId);
}
- return new ArrayList<>(hypervisors);
+ sc.setParameters("type", Host.Type.Routing);
+
+ return _hostDao.customSearch(sc, null).stream()
Review Comment:
can list only unique hypervisor entries here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#discussion_r2052342083
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -3266,12 +3263,16 @@ public List<HostVO> listAllHostsInAllZonesByType(final Type type) {
@Override
public List<HypervisorType> listAvailHypervisorInZone(final Long zoneId) {
- List<VMTemplateVO> systemVMTemplates = _templateDao.listAllReadySystemVMTemplates(zoneId);
- final Set<HypervisorType> hypervisors = new HashSet<>();
- for (final VMTemplateVO systemVMTemplate : systemVMTemplates) {
- hypervisors.add(systemVMTemplate.getHypervisorType());
+ final SearchCriteria<String> sc = _hypervisorsInDC.create();
+ if (zoneId != null) {
+ sc.setParameters("dataCenter", zoneId);
}
- return new ArrayList<>(hypervisors);
+ sc.setParameters("type", Host.Type.Routing);
+
+ return _hostDao.customSearch(sc, null).stream()
Review Comment:
@sureshanaparti SearchBuilder used for this already has DISTINCT statement
https://github.com/apache/cloudstack/blob/4.20/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java#L2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809438367
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809575658
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809469946
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2811769215
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2824702163
@shwstppr , this looks ready to merge, do you feel it is ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2818201642
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2812001225
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2811612302
@shwstppr can you review and fix the build/CI failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809575653
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2819894996
<b>[SF] Trillian test result (tid-13072)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51906 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10738-t13072-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #10738: server: fix available hypervisors listing for a zone
URL: https://github.com/apache/cloudstack/pull/10738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2811771137
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#discussion_r2052357478
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -3266,12 +3263,16 @@ public List<HostVO> listAllHostsInAllZonesByType(final Type type) {
@Override
public List<HypervisorType> listAvailHypervisorInZone(final Long zoneId) {
- List<VMTemplateVO> systemVMTemplates = _templateDao.listAllReadySystemVMTemplates(zoneId);
- final Set<HypervisorType> hypervisors = new HashSet<>();
- for (final VMTemplateVO systemVMTemplate : systemVMTemplates) {
- hypervisors.add(systemVMTemplate.getHypervisorType());
+ final SearchCriteria<String> sc = _hypervisorsInDC.create();
+ if (zoneId != null) {
+ sc.setParameters("dataCenter", zoneId);
}
- return new ArrayList<>(hypervisors);
+ sc.setParameters("type", Host.Type.Routing);
+
+ return _hostDao.customSearch(sc, null).stream()
Review Comment:
ok, thanks for checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2811993797
> > I remember there is a similar method, so looked for it
> > https://github.com/apache/cloudstack/blob/55c811547a8c516c065c99f4d1ede5f43913c4c1/engine/schema/src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java#L168-L178
>
> @weizhouapache are you suggesting using ClusterDao method here or in the callers itself?
if the method returns the same result, we can use it.
the code can be simple as
```
@Override
public List<HypervisorType> listAvailHypervisorInZone(final Long zoneId) {
return _clusterDao.getAvailableHypervisorInZone(zoneId);
}
```
if there is a cluster without any host, then the results will be different ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809440286
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809454117
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10738?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.00%. Comparing base [(`a09354d`)](https://app.codecov.io/gh/apache/cloudstack/commit/a09354ddf5f73744fbc31d024d49db980ae63a63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7188f28`)](https://app.codecov.io/gh/apache/cloudstack/commit/7188f28118839468ac92352db767cc076aff4a5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (a09354d) and HEAD (7188f28). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (a09354d) | HEAD (7188f28) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #10738 +/- ##
=============================================
- Coverage 16.01% 4.00% -12.02%
=============================================
Files 5652 398 -5254
Lines 495921 32525 -463396
Branches 60053 5761 -54292
=============================================
- Hits 79446 1301 -78145
+ Misses 407611 31075 -376536
+ Partials 8864 149 -8715
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10738/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10738/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10738/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10738?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2809468648
Re-kicking smoketests in Github Actions.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix available hypervisors listing for a zone [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #10738:
URL: https://github.com/apache/cloudstack/pull/10738#issuecomment-2825430805
@DaanHoogland yes. Marked it ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org