[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5637: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5637:
URL: https://github.com/apache/incubator-nuttx/pull/5637#discussion_r816888660



##########
File path: arch/arm/src/armv7-a/Toolchain.defs
##########
@@ -59,18 +59,27 @@ ifeq ($(CONFIG_ARM_THUMB),y)
 ARCHCPUFLAGS += -mthumb
 endif
 
-ifeq ($(CONFIG_ARCH_FPU),y)
-ARCHCPUFLAGS += -mfloat-abi=hard
-endif
-
 ifeq ($(CONFIG_ARCH_CORTEXA5),y)
-ARCHCPUFLAGS += -mcpu=cortex-a5
+  ARCHCPUFLAGS += -mcpu=cortex-a5
 else ifeq ($(CONFIG_ARCH_CORTEXA7),y)
-ARCHCPUFLAGS += -mcpu=cortex-a7
+  ARCHCPUFLAGS += -mcpu=cortex-a7
 else ifeq ($(CONFIG_ARCH_CORTEXA8),y)
-ARCHCPUFLAGS += -mcpu=cortex-a8
+  ARCHCPUFLAGS += -mcpu=cortex-a8
 else ifeq ($(CONFIG_ARCH_CORTEXA9),y)
-ARCHCPUFLAGS += -mcpu=cortex-a9
+  ARCHCPUFLAGS += -mcpu=cortex-a9
+endif
+
+ifeq ($(CONFIG_ARCH_FPU),y)
+  ifeq ($(CONFIG_ARCH_CORTEXA8),y)
+    ARCHCPUFLAGS += -mfpu=vfpv3-d16
+  else ifeq ($(CONFIG_ARCH_CORTEXA9),y)
+    ARCHCPUFLAGS += -mfpu=vfpv3-d16
+  else
+    # Just for test, let A8 equal to origin flags
+    ARCHCPUFLAGS += -mfloat-abi=hard -mfpu=vfpv4-d16

Review comment:
       why




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org