[GitHub] [beam] reuvenlax commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options

[GitBox <gi...@apache.org>]

reuvenlax commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r397464252
 
 

 ##########
 File path: sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
 ##########
 @@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor descriptor) {
         // Store proto field number in metadata.
         FieldType fieldType =
             withMetaData(beamFieldTypeFromProtoField(fieldDescriptor), fieldDescriptor);
 
 Review comment:
   I don't want to force all Beam option names to have a prefix - I think that's the wrong approach. I'm suggesting that we create well-known prefixes for these proto options (when translated to Beam options), so we can distinguish them from other options. The prefixes you suggested sound fine to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services