You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Sergiy Matusevych (JIRA)" <ji...@apache.org> on 2016/08/24 22:30:21 UTC

[jira] [Created] (REEF-1544) Use typed SubscriptionHandler instead of deprecated Subscription class

Sergiy Matusevych created REEF-1544:
---------------------------------------

             Summary: Use typed SubscriptionHandler instead of deprecated Subscription class
                 Key: REEF-1544
                 URL: https://issues.apache.org/jira/browse/REEF-1544
             Project: REEF
          Issue Type: Improvement
          Components: REEF-Common
            Reporter: Sergiy Matusevych
            Assignee: Sergiy Matusevych
            Priority: Minor


Class {{Subscription}} is parameterized by token type, but in all use cases (in {{HandlerContainer}} class) it is used with type erasure, and the {{.unsubscribe()}} method checks for all possible subscription tokens manually. This is unsafe and hard to read. A safer mechanism is to use a new {{Subscriptionhandler}} class and deprecate and remove the old subscription logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)