You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/04/11 06:21:29 UTC
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
-----------------------------------------------------------
(Updated April 11, 2016, 4:21 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
Diff: https://reviews.apache.org/r/44131/diff/
Testing (updated)
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
-----------------------------------------------------------
(Updated April 15, 2016, 7:11 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
Diff: https://reviews.apache.org/r/44131/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
-----------------------------------------------------------
(Updated April 15, 2016, 6:32 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
Diff: https://reviews.apache.org/r/44131/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
-----------------------------------------------------------
(Updated April 15, 2016, 1:25 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
Diff: https://reviews.apache.org/r/44131/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/#review128553
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On April 11, 2016, 4:21 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44131/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:21 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
>
> Diff: https://reviews.apache.org/r/44131/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted
`os::` functions on Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/#review128419
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/process.cpp (line 2193)
<https://reviews.apache.org/r/44131/#comment191842>
If it returns a try, you should test for error.
- Joris Van Remoortere
On April 11, 2016, 4:21 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44131/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:21 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97
>
> Diff: https://reviews.apache.org/r/44131/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>