Re: svn commit: r1343540 - /ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt

[Adrian Crum <ad...@sandglass-software.com>]

Adam,

If you don't mind, I would like to clean up the EntityConditionVisitor 
interface so it looks more like a conventional visitor pattern.

-Adrian

On 5/29/2012 5:48 AM, doogie@apache.org wrote:
> Author: doogie
> Date: Tue May 29 04:48:57 2012
> New Revision: 1343540
>
> URL: http://svn.apache.org/viewvc?rev=1343540&view=rev
> Log:
> Add a README with a list of issues from jira that it might be nice
> to have implemented in this branch.
>
> Added:
>      ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt
>
> Added: ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt
> URL: http://svn.apache.org/viewvc/ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt?rev=1343540&view=auto
> ==============================================================================
> --- ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt (added)
> +++ ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt Tue May 29 04:48:57 2012
> @@ -0,0 +1,77 @@
> +Below is a list of issues filed in jira that might be nice to have
> +implemented in this branch.  This list is not absolute.  What is below
> +is just a quick run-through of items I saw that seem to be filed
> +against the entityengine.  Inclusion below does not imply that the
> +request will be implemented.
> +
> +Other items could be added in the future; it would be nice to keep
> +list uptodate as work progresses.
> +
> +
> +OFBIZ-4857
> +	Check in GenericEntity.set whether the new value is different from the current one
> +OFBIZ-4844
> +	Fields in extended entity do not override attribute enable-audit-log
> +OFBIZ-4811
> +	Improving view-entity creation in both XML and DynamicViewEntity to exclude fields declared as Alias from the SQL Select strings
> +OFBIZ-4781
> +	entitymodel - entity-condition inside view-link does not work
> +OFBIZ-4346
> +	Support MySQL and Postgres's LIMIT and OFFSET options
> +OFBIZ-4310
> +	Conversion for complex-alias needs to be implemented
> +OFBIZ-4277
> +	Performance : In TransactionUtil StackTrace begining tracing should not be enabled by default
> +OFBIZ-4240
> +	Override UiLabels / Properties through tenant specific database
> +OFBIZ-4153
> +	Make entity engine a standalone database access tool/API
> +OFBIZ-4053
> +	Implement an Entity Query Builder
> +OFBIZ-3959
> +	Introduce a ModelEntityReaderBuilder to decouple ModelEntity and ModelReader
> +OFBIZ-3946
> +	add an SQL query manager
> +OFBIZ-3880
> +	EntityDateFilterCondition causes the entity cache to return false matches
> +OFBIZ-3748
> +	Remove test specific code in the GenericDelegator
> +OFBIZ-3554
> +	Delegator removeByXXX do not trigger remove ECA
> +OFBIZ-3522
> +	webtools ViewGeneric does not work with entities that have BigDecimal fields
> +OFBIZ-3520
> +	revision 897605 breaks certain delegator.find() EntityListIterator calls
> +OFBIZ-3421
> +	Allow data load to support explicit "null" values for entity update
> +OFBIZ-2866
> +	Allow entity-data-reader to indicate if it should insert, update, or upsert records
> +OFBIZ-1636
> +	delegator.getNextSubSeqId does not guarantee primary key uniqueness
> +OFBIZ-1607
> +	let the ofbiz work with db2
> +OFBIZ-1254
> +	XML Data Export All does not include data present in blob fields
> +OFBIZ-1232
> +	Data filtering in entity views
> +OFBIZ-1033
> +	Ofbiz SQL Integration Features
> +OFBIZ-1032
> +	EntitySaxReader mostly-insert (store after create-error) Fix
> +OFBIZ-1031
> +	GenericDelegator improvements
> +OFBIZ-1030
> +	Ofbiz SQL-Logging Extension
> +OFBIZ-1029
> +	TransactionUtil Refactoring
> +OFBIZ-1026
> +	EntityOperator IN_SUBQUERY enhancement
> +OFBIZ-836
> +	Bug in SqlJdbcUtil.java regarding outer join in oracle theta join mode
> +OFBIZ-810
> +	Improve export/import services
> +OFBIZ-563
> +	Entity Model Reader needs reserved word check
> +OFBIZ-293
> +	data import - nulling fields impossible
> +
>
>

Re: svn commit: r1343540 - /ofbiz/branches/improved-entityengine-features-20120528/README-improved-entityengine-features.txt

[Jacopo Cappellato <ja...@hotwaxmedia.com>]

On May 29, 2012, at 10:47 AM, Adrian Crum wrote:

>> +OFBIZ-4053
>> +	Implement an Entity Query Builder

I see a big potential in the above one, if properly implemented; the builder pattern could be very nice when used in groovy; and we could expand it to also provide support for views; I actually think that a nice entity query/view builder would help to:

1) make the code more efficient (less number of nested queries using more joined queries); the DynamicViewEntity api is not very developer friendly
2) slim down the number of view entities defined in xml: I don't like them because the definitions are too far from the code; because most of the time the view entity is only used in one place and so it unnecessarily pollute the entity definition files

Jacopo