You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/04/28 13:49:24 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23865: fix: Native time range filter in legacy charts
codecov[bot] commented on PR #23865:
URL: https://github.com/apache/superset/pull/23865#issuecomment-1527595292
## [Codecov](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23865](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (774adcf) into [master](https://codecov.io/gh/apache/superset/commit/053dca10bd459d23a2bec3383082c3c9572db65e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (053dca1) will **decrease** coverage by `11.39%`.
> The diff coverage is `80.76%`.
> :exclamation: Current head 774adcf differs from pull request most recent head 4b4c0c3. Consider uploading reports for the commit 4b4c0c3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23865 +/- ##
===========================================
- Coverage 68.11% 56.72% -11.39%
===========================================
Files 1938 1938
Lines 74958 74975 +17
Branches 8141 8141
===========================================
- Hits 51055 42527 -8528
- Misses 21824 30369 +8545
Partials 2079 2079
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.92% <64.28%> (-0.01%)` | :arrow_down: |
| python | `59.11% <78.57%> (-23.56%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.81% <78.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/legacy-plugin-chart-calendar/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNhbGVuZGFyL3NyYy9jb250cm9sUGFuZWwudHM=) | `50.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `55.96% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `64.80% <57.14%> (-26.20%)` | :arrow_down: |
| [...tend/src/components/Chart/DrillBy/DrillByModal.tsx](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxCeS9EcmlsbEJ5TW9kYWwudHN4) | `74.13% <75.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/logger/LogUtils.ts](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy50cw==) | `97.14% <100.00%> (+0.36%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/23865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `75.34% <100.00%> (-23.27%)` | :arrow_down: |
... and [305 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23865/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org