You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/12 22:15:57 UTC
[GitHub] [spark] williamhyun opened a new pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
williamhyun opened a new pull request #30020:
URL: https://github.com/apache/spark/pull/30020
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707425227
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708887170
**[Test build #129794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129794/testReport)** for PR 30020 at commit [`3d06ddb`](https://github.com/apache/spark/commit/3d06ddbaa789fdc348ace0b50af43b304089e94f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711713822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711617612
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707452475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707439641
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707406757
**[Test build #129715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129715/testReport)** for PR 30020 at commit [`b40f3be`](https://github.com/apache/spark/commit/b40f3be18b200992c1567fe03d789e79a59d2674).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707374183
**[Test build #129711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129711/testReport)** for PR 30020 at commit [`7f66477`](https://github.com/apache/spark/commit/7f66477e0529d841856609211c188938b5d683cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708907373
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34401/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707452475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711558322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708883041
Thanks. But the comment of `determine_modules_for_files` seems not updated https://github.com/apache/spark/pull/30020#pullrequestreview-506989673?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] williamhyun commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711552184
Thank you @viirya, sorry for being late to implement the feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] williamhyun commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707406647
@viirya I updated the code, could you review once more? Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
viirya removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711572989
Pending test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711630459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] williamhyun commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708881663
Thank you, @viirya @HyukjinKwon !
I updated my PR according to your advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711630459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711715042
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129983/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711602959
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34590/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711717003
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129981/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708947992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30020:
URL: https://github.com/apache/spark/pull/30020#discussion_r507457610
##########
File path: dev/run-tests.py
##########
@@ -55,6 +56,8 @@ def determine_modules_for_files(filenames):
for filename in filenames:
if filename in ("appveyor.yml",):
continue
+ if (os.environ.get("AMPLAB_JENKINS") and filename.startswith(".github")):
Review comment:
```suggestion
if ("GITHUB_ACTIONS" not in os.environ) and filename.startswith(".github"):
```
##########
File path: dev/run-tests.py
##########
@@ -42,7 +42,8 @@ def determine_modules_for_files(filenames):
"""
Given a list of filenames, return the set of modules that contain those files.
If a file is not associated with a more specific submodule, then this method will consider that
- file to belong to the 'root' module. GitHub Action and Appveyor files are ignored.
+ file to belong to the 'root' module. `.github` directory is ignored if AMPLAB_JENKINS is defined
+ and Appveyor files are ignored always.
Review comment:
```suggestion
file to belong to the 'root' module. `.github` directory is counted only in GitHub Actions,
and `appveyor.yml` is always ignored because this file is dedicated only to AppVeyor builds.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708946601
**[Test build #129794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129794/testReport)** for PR 30020 at commit [`3d06ddb`](https://github.com/apache/spark/commit/3d06ddbaa789fdc348ace0b50af43b304089e94f).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711558322
**[Test build #129981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129981/testReport)** for PR 30020 at commit [`c202e8a`](https://github.com/apache/spark/commit/c202e8a93e7a1aaa7fb36a07c4c51162ff3358d0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711573534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708912967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707425231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34321/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707396480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30020:
URL: https://github.com/apache/spark/pull/30020#discussion_r503615658
##########
File path: dev/run-tests.py
##########
@@ -55,6 +55,10 @@ def determine_modules_for_files(filenames):
for filename in filenames:
if filename in ("appveyor.yml",):
continue
+ if (os.environ.get("AMPLAB_JENKINS") and
+ filename in (".github/workflows/build_and_test.yml",
Review comment:
I think even we can just ignore running build for entire `.github` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707425227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708887170
**[Test build #129794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129794/testReport)** for PR 30020 at commit [`3d06ddb`](https://github.com/apache/spark/commit/3d06ddbaa789fdc348ace0b50af43b304089e94f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30020:
URL: https://github.com/apache/spark/pull/30020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711716993
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708912953
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34401/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711715036
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707451736
**[Test build #129715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129715/testReport)** for PR 30020 at commit [`b40f3be`](https://github.com/apache/spark/commit/b40f3be18b200992c1567fe03d789e79a59d2674).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711716993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707439648
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129711/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707439641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711630429
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707406757
**[Test build #129715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129715/testReport)** for PR 30020 at commit [`b40f3be`](https://github.com/apache/spark/commit/b40f3be18b200992c1567fe03d789e79a59d2674).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711617627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707374183
**[Test build #129711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129711/testReport)** for PR 30020 at commit [`7f66477`](https://github.com/apache/spark/commit/7f66477e0529d841856609211c188938b5d683cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707396469
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34317/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30020:
URL: https://github.com/apache/spark/pull/30020#discussion_r503594031
##########
File path: dev/run-tests.py
##########
@@ -55,6 +55,9 @@ def determine_modules_for_files(filenames):
for filename in filenames:
if filename in ("appveyor.yml",):
continue
+ if (os.environ.get("AMPLAB_JENKINS") and
+ filename in (".github/workflows/build_and_test.yml",)):
+ continue
Review comment:
Shall we also include `test_report.yml` and `stale.yml`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708947992
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711046796
Hi @williamhyun would you like to quickly update the comment of `determine_modules_for_files` (https://github.com/apache/spark/pull/30020#pullrequestreview-506989673) so I can merge this? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708948003
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129794/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-708912967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707425213
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34321/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711572989
Pending test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711610295
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711577577
**[Test build #129983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129983/testReport)** for PR 30020 at commit [`4901cde`](https://github.com/apache/spark/commit/4901cde620f0482b1a2021d151da8f906d110c72).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711582524
Yeah, technically we had to wait for the test results. I manually tested and updated PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711715036
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] williamhyun commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #30020:
URL: https://github.com/apache/spark/pull/30020#discussion_r503595577
##########
File path: dev/run-tests.py
##########
@@ -55,6 +55,9 @@ def determine_modules_for_files(filenames):
for filename in filenames:
if filename in ("appveyor.yml",):
continue
+ if (os.environ.get("AMPLAB_JENKINS") and
+ filename in (".github/workflows/build_and_test.yml",)):
+ continue
Review comment:
Sure I'll add them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707438791
**[Test build #129711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129711/testReport)** for PR 30020 at commit [`7f66477`](https://github.com/apache/spark/commit/7f66477e0529d841856609211c188938b5d683cf).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30020: [SPARK-33123][INFRA] Ignore GitHub only changes in Amplab Jenkins build
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-711617627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30020:
URL: https://github.com/apache/spark/pull/30020#discussion_r503660823
##########
File path: dev/run-tests.py
##########
@@ -55,6 +55,10 @@ def determine_modules_for_files(filenames):
for filename in filenames:
if filename in ("appveyor.yml",):
continue
+ if (os.environ.get("AMPLAB_JENKINS") and
+ filename in (".github/workflows/build_and_test.yml",
Review comment:
sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707391032
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34317/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707419385
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34321/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30020: [SPARK-33123][TESTS] Ignore `GitHub Action file` change in Amplab Jenkins
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30020:
URL: https://github.com/apache/spark/pull/30020#issuecomment-707396480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org