You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/09 04:58:48 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4565: [Feature-#4549][remote]Rpc design
codecov-io edited a comment on pull request #4565:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4565#issuecomment-766866517
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=h1) Report
> Merging [#4565](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=desc) (1c047e4) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/66b8288d1f4ef301a20c5c8fcffb241605251816?el=desc) (66b8288) will **increase** coverage by `0.81%`.
> The diff coverage is `73.05%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4565 +/- ##
============================================
+ Coverage 45.12% 45.93% +0.81%
- Complexity 3379 3519 +140
============================================
Files 537 565 +28
Lines 23072 23651 +579
Branches 2688 2719 +31
============================================
+ Hits 10411 10864 +453
- Misses 11735 11822 +87
- Partials 926 965 +39
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dolphinscheduler/remote/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NvbnN0YW50cy5qYXZh) | `71.42% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...dolphinscheduler/rpc/common/ResponseEventType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9SZXNwb25zZUV2ZW50VHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...inscheduler/rpc/protocol/RpcProtocolConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3Byb3RvY29sL1JwY1Byb3RvY29sQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lphinscheduler/rpc/serializer/ProtoStuffUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3NlcmlhbGl6ZXIvUHJvdG9TdHVmZlV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/dolphinscheduler/rpc/future/RpcFuture.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2Z1dHVyZS9ScGNGdXR1cmUuamF2YQ==) | `43.47% <43.47%> (ø)` | `3.00 <3.00> (?)` | |
| [...he/dolphinscheduler/remote/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `84.61% <50.00%> (ø)` | `7.00 <3.00> (ø)` | |
| [...olphinscheduler/rpc/remote/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3JlbW90ZS9OZXR0eUNsaWVudEhhbmRsZXIuamF2YQ==) | `51.16% <51.16%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/dolphinscheduler/rpc/common/RpcResponse.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9ScGNSZXNwb25zZS5qYXZh) | `53.84% <53.84%> (ø)` | `5.00 <5.00> (?)` | |
| [...nscheduler/rpc/common/ConsumerConfigConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9Db25zdW1lckNvbmZpZ0NvbnN0YW50cy5qYXZh) | `60.00% <60.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...lphinscheduler/rpc/client/ConsumerConfigCache.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NsaWVudC9Db25zdW1lckNvbmZpZ0NhY2hlLmphdmE=) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [68 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=footer). Last update [66b8288...1c047e4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org