You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:56:58 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #18031: [fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink
coderzc opened a new pull request, #18031:
URL: https://github.com/apache/pulsar/pull/18031
### Modifications
When install `pulsar-io-jdbc-mariadb` module occurred checkstyle error.
> mvn clean install -pl pulsar-io/jdbc/mariadb
```
[INFO] --- maven-checkstyle-plugin:3.1.2:check (checkstyle) @ pulsar-io-jdbc-mariadb ---
[INFO] There is 1 error reported by Checkstyle 8.37 with /Users/zc/IdeaProjects/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/pulsar/io/jdbc/MariadbJdbcAutoSchemaSink.java:[23,8] (imports) UnusedImports: Unused import: java.util.stream.Collectors.
```
Related PR：#17950
### Modifications
Remove unused import statement in the MariadbJdbcAutoSchemaSink.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/coderzc/pulsar/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18031: [fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18031:
URL: https://github.com/apache/pulsar/pull/18031#issuecomment-1277302501
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18031?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18031](https://codecov.io/gh/apache/pulsar/pull/18031?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (442048b) into [master](https://codecov.io/gh/apache/pulsar/commit/6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c65ca0) will **decrease** coverage by `4.71%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/pulsar/pull/18031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18031 +/- ##
============================================
- Coverage 34.91% 30.20% -4.72%
+ Complexity 5707 3948 -1759
============================================
Files 607 393 -214
Lines 53396 43422 -9974
Branches 5712 4462 -1250
============================================
- Hits 18644 13114 -5530
+ Misses 32119 28398 -3721
+ Partials 2633 1910 -723
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `30.20% <40.00%> (-4.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/pulsar/compaction/CompactedTopicImpl.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vQ29tcGFjdGVkVG9waWNJbXBsLmphdmE=) | `11.42% <0.00%> (+0.71%)` | :arrow_up: |
| [...broker/delayed/InMemoryDelayedDeliveryTracker.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9kZWxheWVkL0luTWVtb3J5RGVsYXllZERlbGl2ZXJ5VHJhY2tlci5qYXZh) | `22.00% <50.00%> (+22.00%)` | :arrow_up: |
| [.../pulsar/broker/service/SharedConsumerAssignor.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NoYXJlZENvbnN1bWVyQXNzaWdub3IuamF2YQ==) | `3.70% <0.00%> (-64.82%)` | :arrow_down: |
| [...ion/pendingack/impl/MLPendingAckStoreProvider.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9wZW5kaW5nYWNrL2ltcGwvTUxQZW5kaW5nQWNrU3RvcmVQcm92aWRlci5qYXZh) | `16.86% <0.00%> (-50.61%)` | :arrow_down: |
| [...tent/NonPersistentDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudERpc3BhdGNoZXJNdWx0aXBsZUNvbnN1bWVycy5qYXZh) | `0.00% <0.00%> (-48.15%)` | :arrow_down: |
| [...saction/recover/TransactionRecoverTrackerImpl.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9yZWNvdmVyL1RyYW5zYWN0aW9uUmVjb3ZlclRyYWNrZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-45.17%)` | :arrow_down: |
| [...apache/pulsar/broker/service/TopicListService.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1RvcGljTGlzdFNlcnZpY2UuamF2YQ==) | `10.65% <0.00%> (-44.27%)` | :arrow_down: |
| [...saction/timeout/TransactionTimeoutTrackerImpl.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi90aW1lb3V0L1RyYW5zYWN0aW9uVGltZW91dFRyYWNrZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-43.86%)` | :arrow_down: |
| [...ar/broker/transaction/util/LogIndexLagBackoff.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi91dGlsL0xvZ0luZGV4TGFnQmFja29mZi5qYXZh) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...ion/buffer/matadata/TransactionBufferSnapshot.java](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvbWF0YWRhdGEvVHJhbnNhY3Rpb25CdWZmZXJTbmFwc2hvdC5qYXZh) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| ... and [300 more](https://codecov.io/gh/apache/pulsar/pull/18031/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18031: [fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18031: [fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink
URL: https://github.com/apache/pulsar/pull/18031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18031: [fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18031:
URL: https://github.com/apache/pulsar/pull/18031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org