You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/10/05 11:07:32 UTC

[GitHub] tinkerpop issue #949: TINKERPOP-2056 Use NumberHelper in Compare

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/949
  
    Just pushed a commit 4bdb006c5ee418f27ef7bb8a9330714ce414c50f on the release branches to deal with these pesky tests that sometimes fail in travis:
    
    ```text
    [ERROR]   GremlinGroovyScriptEngineTest.shouldAllowsUseToBeExecutedAfterImport:293 » Runtime
    [ERROR]   GremlinGroovyScriptEngineTest.shouldLoadImportsViaDependencyManagerFromDependencyGatheredByUse:279 » Runtime
    ```
    
    Obviously not related to this change. Did you happen to do any tests to see what this optimization bought us in terms of performance?
    
    VOTE +1


---