You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Kim van der Riet (JIRA)" <ji...@apache.org> on 2011/06/01 16:05:47 UTC

[jira] [Created] (QPID-3288) [C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties

[C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties
-----------------------------------------------------------------------------------------------------------------

                 Key: QPID-3288
                 URL: https://issues.apache.org/jira/browse/QPID-3288
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
            Reporter: Kim van der Riet
            Assignee: Kim van der Riet


When handling the start() and startOk() methods in ConnectionHandler::Handler, the broker fails to check the client/server properties FieldTable for the presence of the federation tag correctly. Rather, it simply gets the tag as a string, and this in turn returns an empty string when it is not present. Not only this, but no check is made for the presence of the federation flag (which is also not present in such cases) prior to setting this string.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3288) [C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties

Posted by "Kim van der Riet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim van der Riet resolved QPID-3288.
------------------------------------

    Resolution: Fixed

Fixed in r.1132623

> [C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3288
>                 URL: https://issues.apache.org/jira/browse/QPID-3288
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>            Reporter: Kim van der Riet
>            Assignee: Kim van der Riet
>
> When handling the start() and startOk() methods in ConnectionHandler::Handler, the broker fails to check the client/server properties FieldTable for the presence of the federation tag correctly. Rather, it simply gets the tag as a string, and this in turn returns an empty string when it is not present. Not only this, but no check is made for the presence of the federation flag (which is also not present in such cases) prior to setting this string.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3288) [C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties

Posted by "Kim van der Riet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043350#comment-13043350 ] 

Kim van der Riet commented on QPID-3288:
----------------------------------------

Code review request is at https://reviews.apache.org/r/850/

> [C++] Broker sets federation link tag as empty string ("") when no tag is present in the client/server properties
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3288
>                 URL: https://issues.apache.org/jira/browse/QPID-3288
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>            Reporter: Kim van der Riet
>            Assignee: Kim van der Riet
>
> When handling the start() and startOk() methods in ConnectionHandler::Handler, the broker fails to check the client/server properties FieldTable for the presence of the federation tag correctly. Rather, it simply gets the tag as a string, and this in turn returns an empty string when it is not present. Not only this, but no check is made for the presence of the federation flag (which is also not present in such cases) prior to setting this string.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org