Re: [PR] Make CREATE MATERIALIZED VIEW DDL pluggable via MaterializedViewDdlHandler [pinot]

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #18639:
URL: https://github.com/apache/pinot/pull/18639#discussion_r3333992869


##########
pinot-sql-ddl/src/main/java/org/apache/pinot/sql/ddl/compile/MaterializedViewPropertyRouter.java:
##########
@@ -244,7 +254,7 @@ public static void apply(Map<String, String> properties, String definedSql,
       mvTaskConfig.put(SCHEDULE_KEY, schedule);
     }
 
-    taskConfigs.put(MaterializedViewTask.TASK_TYPE, mvTaskConfig);
+    taskConfigs.put(mvTaskType, mvTaskConfig);

Review Comment:
   `task.<customTaskType>.*` entries are lost on the new extension path. The loop stores those prefixed properties in `taskConfigs[taskType]`, but this final `put(mvTaskType, mvTaskConfig)` replaces that whole map when `taskType == mvTaskType`. Any handler-specific task knobs disappear from the persisted `TableConfig`, so the new extension can accept a config that runtime code later sees without the settings it depends on. Please merge the existing map into `mvTaskConfig` instead of overwriting it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org