You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Nicolas Richeton (JIRA)" <ji...@apache.org> on 2010/04/18 19:17:25 UTC

[jira] Created: (WICKET-2840) Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()

Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()
---------------------------------------------------------------------

                 Key: WICKET-2840
                 URL: https://issues.apache.org/jira/browse/WICKET-2840
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4.7
            Reporter: Nicolas Richeton


Could final be removed of AbstractRequestTargetUrlCodingStrategy#getMountPath() ? 

I have a usecase where I need to mount a same page on several paths depending on the locale : 
- the login page is mounted on /login when the site is in english, and /connexion when the site is in french
- The inverse should return 404 -> /login in french or /connexion in english
- All links should link directly to the right page according to the site language

The best way I found to implement this is to override AbstractRequestTargetUrlCodingStrategy#getMountPath() but because of the final qualifier, a lot of code has to be duplicated. Why is this method final and could it be removed ?  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Resolved: (WICKET-2840) Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2840.
-----------------------------------

         Assignee: Igor Vaynberg
    Fix Version/s: 1.4.9
       Resolution: Fixed

> Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()
> ---------------------------------------------------------------------
>
>                 Key: WICKET-2840
>                 URL: https://issues.apache.org/jira/browse/WICKET-2840
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.7
>            Reporter: Nicolas Richeton
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.9
>
>
> Could final be removed of AbstractRequestTargetUrlCodingStrategy#getMountPath() ? 
> I have a usecase where I need to mount a same page on several paths depending on the locale : 
> - the login page is mounted on /login when the site is in english, and /connexion when the site is in french
> - The inverse should return 404 -> /login in french or /connexion in english
> - All links should link directly to the right page according to the site language
> The best way I found to implement this is to override AbstractRequestTargetUrlCodingStrategy#getMountPath() but because of the final qualifier, a lot of code has to be duplicated. Why is this method final and could it be removed ?  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.