You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 08:58:59 UTC

[GitHub] [pulsar] shibd opened a new pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

shibd opened a new pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998


   ### Motivation
   
   #11979 
   
   
   ### Modifications
   
   -  Need `incrementUnackedMessages` when send message to consumer(all subscribe mode)
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Need to update docs? 
   
   - [ ] doc-required 
   - [x] no-need-doc 
   - [ ] doc 
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd edited a comment on pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd edited a comment on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-917663949


   > Looks good, can we add/update existing unit test to verify it? Probably at here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
   
   @MarvinCai  Thank you reply. This PR Maybe it's not right, It will change the original design. I noticed `addAndGetUnAckedMsgs` method  is only call  when the `isIndividualAckMode(subscribe model eq Shared / Key_Shared)`.
   
   Do you know why it's designed like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd closed pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd closed pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd removed a comment on pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd removed a comment on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-917663949


   > Looks good, can we add/update existing unit test to verify it? Probably at here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
   
   @MarvinCai  Thank you reply. This PR Maybe it's not right, It will change the original design. I noticed `addAndGetUnAckedMsgs` method  is only call  when the `isIndividualAckMode(subscribe model eq Shared / Key_Shared)`.
   
   Do you know why it's designed like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd commented on pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-917786603


   > Looks good, can we add/update existing unit test to verify it? Probably at here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
   
   @MarvinCai  Thank you reply. This PR Maybe it's not right, It will change the original design. I'll close the PR, I will discuss this in issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd commented on pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-916747847


   @jerrypeng Can you help me review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd commented on pull request #11998: [Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)

Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-917663949


   > Looks good, can we add/update existing unit test to verify it? Probably at here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
   
   @MarvinCai  Thanks you reply. This PR Maybe it's not right, It will change the original design. I noticed `addAndGetUnAckedMsgs` method  is only call  when the `isIndividualAckMode(subscribe model eq Shared / Key_Shared)`.
   
   Do you know why it's designed like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org