You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/01 00:58:10 UTC
[kudu-CR] Fix security tests on macOS
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6176
to look at the new patch set (#4).
Change subject: Fix security tests on macOS
......................................................................
Fix security tests on macOS
This fixes a few issues:
* The macOS Heimdal Kerberos implementation stubs out
krb5_aname_to_localname. Workaround is to grab the username from the
principal instead of doing the full mapping, this should be good
enough for now.
* The curl library was linking against the system OpenSSL, to fix this
I rejiggered how we pass OpenSSL include and link flags to the
thirdparty dependencies which need them. In my opinion it's a little
bit cleaner now.
* Another test was failing because of Heimdal caching the
non-existence of credentials, the test has been disabled, since
there is no known workaround for this (it happens in
negotiation-test.cc as well).
Change-Id: I1ff10fa47cb7b8ec6f927619e1420fa5e81a7f20
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc-test.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
5 files changed, 62 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6176/4
--
To view, visit http://gerrit.cloudera.org:8080/6176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ff10fa47cb7b8ec6f927619e1420fa5e81a7f20
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins