You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Al Maw <wi...@almaw.com> on 2007/06/20 11:22:34 UTC

Application#internalInit() - should be final?

Howdy,

Application#internalInit() isn't final. However, if you override it and 
don't call super.internalInit(), you won't add the session store, the 
converter locator, any of the component resolvers, etc. etc.

Obviously you have the init() method to configure your app with. So 
surely internalInit() should be made final?

Regards,

Al

-- 
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Re: Application#internalInit() - should be final?

Posted by Al Maw <wi...@almaw.com>.
Johan Compagner wrote:
> yeah webapplication could make that final. (same as the internalDestroy)
> But still if people would make there own none webapplication we would still
> have the same problem.

Yeah, I noticed after I sent this that it breaks the 
SpringWebApplication, for example. :-(

We need IApplicationFacet and all that. ;-)

Regards,

Al

-- 
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Re: Application#internalInit() - should be final?

Posted by Johan Compagner <jc...@gmail.com>.
yeah webapplication could make that final. (same as the internalDestroy)
But still if people would make there own none webapplication we would still
have the same problem.

would be nice to have some different scope in java like "friends" or thinks
like
protected only for xxxx
or
final protected except for xxxx





On 6/20/07, Al Maw <wi...@almaw.com> wrote:
>
> Al Maw wrote:
> > Application#internalInit() isn't final. However, if you override it and
> > don't call super.internalInit(), you won't add the session store, the
> > converter locator, any of the component resolvers, etc. etc.
> >
> > Obviously you have the init() method to configure your app with. So
> > surely internalInit() should be made final?
>
> Errr, on WebApplication, I mean, obviously.
>
> Al
> --
> Alastair Maw
> Wicket-biased blog at http://herebebeasties.com
>

Re: Application#internalInit() - should be final?

Posted by Al Maw <wi...@almaw.com>.
Al Maw wrote:
> Application#internalInit() isn't final. However, if you override it and 
> don't call super.internalInit(), you won't add the session store, the 
> converter locator, any of the component resolvers, etc. etc.
> 
> Obviously you have the init() method to configure your app with. So 
> surely internalInit() should be made final?

Errr, on WebApplication, I mean, obviously.

Al
-- 
Alastair Maw
Wicket-biased blog at http://herebebeasties.com