You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by nkalmar <gi...@git.apache.org> on 2018/06/26 13:32:30 UTC
[GitHub] zookeeper pull request #550: ZOOKEEPER-3022 - Iteration 1 - docs, it
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/550
ZOOKEEPER-3022 - Iteration 1 - docs, it
First iteration of the directory changes in maven migration.
This time, the empty zookeeper-it for future integration tests were created, and the docs source were moved to zookeeper-docs.
Tested with forest v0.9, documents generations were successful with ant.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3022-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #550
----
commit 93c44dfcfec7755413a3da938564c12748fa5c36
Author: Norbert Kalmar <nk...@...>
Date: 2018-06-26T13:30:40Z
ZOOKEEPER-3022 - Iteration 1 - docs, it
----
---
[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/550
Thanks @nkalmar, looks good to me.
One nitpick only: add "MAVEN MIGRATION" to the title of all these PRs in capitals, just to make it obvious for everybody that you're making progress.
---
[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - MAVEN MIGRATION - Iteration 1 - docs,...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/550
Committed to master and 3.5 branches. Thanks @nkalmar
---
[GitHub] zookeeper pull request #550: ZOOKEEPER-3022 - MAVEN MIGRATION - Iteration 1 ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/550
---
[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/550
You're right @anmolnar , I also realised after seeing the PR that I should have added some text indicating this is part of the migration. I will add it in the future, thanks.
---