You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2024/04/17 19:44:58 UTC
[PR] fix(explore): cannot reorder dnd of Metrics [superset]
justinpark opened a new pull request, #28111:
URL: https://github.com/apache/superset/pull/28111
### SUMMARY
Fixes #28013
Due to the issue of the metric dnd item containing with an invalid property name for dragIndex, the highlight dropzone has been overlapping with the dragging item. As a result, the dnd of metrics cannot be reordered effectively.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/apache/superset/assets/1392866/be1920d0-137f-42ff-9d6b-41c42717ba07
After:
https://github.com/apache/superset/assets/1392866/e384c920-1a7c-47a7-8643-d891db3bec5a
### TESTING INSTRUCTIONS
Go to Charts
Get two metrics in the metrics pane for Table view
Try to reorder them.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): cannot reorder dnd of Metrics [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #28111:
URL: https://github.com/apache/superset/pull/28111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): cannot reorder dnd of Metrics [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28111:
URL: https://github.com/apache/superset/pull/28111#issuecomment-2064249266
<img src="https://media1.giphy.com/media/PApUm1HPVYlDNLoMmr/giphy.gif"/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): cannot reorder dnd of Metrics [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #28111:
URL: https://github.com/apache/superset/pull/28111#issuecomment-2062141893
> could you check if the name `dragIndex` won't generate a console warning before merging the PR?
No warning messages. (Since it's a draggable item metadata, the naming of dragIndex is considered safe.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org