You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/25 20:32:35 UTC

[GitHub] [thrift] kinoroy commented on a diff in pull request #2719: THRIFT-5657: Use Swift 5.7 in all CI (github actions + travis)

kinoroy commented on code in PR #2719:
URL: https://github.com/apache/thrift/pull/2719#discussion_r1004938123


##########
.github/workflows/build.yml:
##########
@@ -275,6 +275,11 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Setup Swift
+        uses: swift-actions/setup-swift@v1.18.0
+        with:
+          swift-version: "5.7"

Review Comment:
   I agree I like the old Travis way of having a docker container with everything setup in it. I'm not sure if you can do that on GitHub actions but I'd support that 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org