You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/18 15:23:22 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #10957: fix: re-enabling several globally disabled lint rules
kkucharc opened a new pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957
### SUMMARY
Several lint rules which are globally disabled may be enabled again:
- `bad-continuation` - it is solved by black,
- `duplicate-code` - there are no duplications and it may help with keeping DRY rule,
- `dict-iter-method` - since in Python 3 it isn't possible use old iterating methods,
- `invalid-unary-operand-type` - all unary operators are used properly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957#issuecomment-694939696
@willbarrett this is suggestions of several rules in `.pylintrc` which may be enabled again. Would you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc edited a comment on pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
kkucharc edited a comment on pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957#issuecomment-695967914
Thank you @mistercrunch for the review.
cc: @willbarrett I believe it's ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957#issuecomment-695967914
Thank you @mistercrunch for the review.
cc: @willbarrett I believe it's ready for PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957#issuecomment-695967914
Thank you @mistercrunch for the review.
cc: @willbarrett I believe it's ready for PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc edited a comment on pull request #10957: fix: re-enabling several globally disabled lint rules
Posted by GitBox <gi...@apache.org>.
kkucharc edited a comment on pull request #10957:
URL: https://github.com/apache/incubator-superset/pull/10957#issuecomment-695967914
Thank you @mistercrunch for the review.
cc: @willbarrett I believe it's ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org