You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/28 01:27:32 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9030:
[fix] Reverting metic logic from #8901
john-bodley opened a new pull request #9030: [fix] Reverting metic logic from #8901
URL: https://github.com/apache/incubator-superset/pull/9030
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This PR reverts the metric cleanup logic defined in https://github.com/apache/incubator-superset/pull/8901 as the superset-ui currently defines the metrics in the form `{"label": <name>}` per [here](https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-query/src/convertMetric.ts#L20).
Given that the superset-ui build is currently broken (though is actively being worked on) it seems like reverting the so-called temporary logic probably makes the most sense for now.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @villebro
cc: @williaster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] williaster commented on issue #9030: [fix]
Reverting metic logic from #8901
Posted by GitBox <gi...@apache.org>.
williaster commented on issue #9030: [fix] Reverting metic logic from #8901
URL: https://github.com/apache/incubator-superset/pull/9030#issuecomment-579394146
thanks @john-bodley ! would be curious to hear any thoughts you have on how best to add the end-to-end tests. perhaps if the API v2 gets fleshed out (I think there are plans in the works for this), it would be a good time to add cc @kristw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on issue #9030: [fix]
Reverting metic logic from #8901
Posted by GitBox <gi...@apache.org>.
john-bodley commented on issue #9030: [fix] Reverting metic logic from #8901
URL: https://github.com/apache/incubator-superset/pull/9030#issuecomment-579100257
@villebro agreed. Ideally there should be some CI checks or offline end-to-end test suite which verifies consistency between these packages especially as we are going to lean on the `superset-ui` package for the frontend logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9030: [fix]
Reverting metic logic from #8901
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9030: [fix] Reverting metic logic from #8901
URL: https://github.com/apache/incubator-superset/pull/9030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org