[GitHub] [airflow] kaxil commented on a change in pull request #10266: Add reconcile_metadata to reconcile_pods

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #10266:
URL: https://github.com/apache/airflow/pull/10266#discussion_r468598872



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -357,12 +357,35 @@ def reconcile_pods(base_pod: k8s.V1Pod, client_pod: Optional[k8s.V1Pod]) -> k8s.
 
         client_pod_cp = copy.deepcopy(client_pod)
         client_pod_cp.spec = PodGenerator.reconcile_specs(base_pod.spec, client_pod_cp.spec)
-
-        client_pod_cp.metadata = merge_objects(base_pod.metadata, client_pod_cp.metadata)
+        client_pod_cp.metadata = PodGenerator.reconcile_metadata(base_pod.metadata, client_pod_cp.metadata)
         client_pod_cp = merge_objects(base_pod, client_pod_cp)
 
         return client_pod_cp
 
+    @staticmethod
+    def reconcile_metadata(base_meta, client_meta):
+        """

Review comment:
       Can you add a single line description of this function please




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org