You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/11/06 02:59:11 UTC
[GitHub] [rocketmq] ShadowySpirits opened a new issue #1576: Bug in select
MessageQueue
ShadowySpirits opened a new issue #1576: Bug in select MessageQueue
URL: https://github.com/apache/rocketmq/issues/1576
When SendLatencyFaultEnable is enabled and the currently selected message is available, you need to make sure that the currently selected broker is not the last selected.
But this judgment is wrong for now:
```java
// MQFaultStrategy#selectOneMessageQueue
MessageQueue mq = tpInfo.getMessageQueueList().get(pos);
if (latencyFaultTolerance.isAvailable(mq.getBrokerName())) {
// this judgment shuold be change to if(!mq.getBrokerName().equals(lastBrokerName))
if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
return mq;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services