You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "appasuamithsai (via GitHub)" <gi...@apache.org> on 2023/03/27 07:03:56 UTC
[GitHub] [superset] appasuamithsai opened a new pull request, #23492: bug fix 16481
appasuamithsai opened a new pull request, #23492:
URL: https://github.com/apache/superset/pull/23492
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In table, metric column and # column has right alignment while other type of column has left alignment
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="1512" alt="Screenshot 2023-03-20 at 12 02 09 PM" src="https://user-images.githubusercontent.com/94451692/226268379-9a3bccbd-9ab5-4dab-85e0-c8020bbde750.png">
<img width="1512" alt="Screenshot 2023-03-20 at 12 02 25 PM" src="https://user-images.githubusercontent.com/94451692/226268421-a9a22010-acdf-4f6d-b520-7a019516dbc0.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
<ol>
<li>Go to table chart , select different type of column in raw</li>
<li>Click on run and observe the table chart</li>
</ol>
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ x] Has associated issue: https://github.com/apache/superset/issues/16481
- [ ] Required feature flags:
- [x ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #23492: bug fix 16481
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #23492:
URL: https://github.com/apache/superset/pull/23492#issuecomment-1564866829
I agree that it may not make sense to change this now, since there's already a customization option for the alignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #23492: bug fix 16481
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23492: bug fix 16481
URL: https://github.com/apache/superset/pull/23492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23492: bug fix 16481
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23492:
URL: https://github.com/apache/superset/pull/23492#issuecomment-1553748750
@yousoph @kasiazjc I see this closes a long-standing Issue, but I'm not sure if this is good or bad. Yes, it makes the columns consistent, but many would hold the opinion that right-aligned numbers are easier to compare.
Since the alignment of columns is already customizable in the Table plugin, does it make sense to change the current default?
<img width="648" alt="image" src="https://github.com/apache/superset/assets/812905/3b913d1a-ec3a-42f0-9ab3-99e91353f416">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23492: bug fix 16481
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23492:
URL: https://github.com/apache/superset/pull/23492#issuecomment-1652127307
Ok. Let's not do this for now. I've closed the underlying issue that this resolves, as well, since the current behavior is
• the more desirable state (left-aligned text, right-aligned numbers for easier comparison)
• overridable via existing chart controls under "customize"
If anyone finds this controversial (particularly @appasuamithsai ) then we can re-visit this, possibly taking the discussion to the mailing list or another venue for a wider audience. Maybe a path forward would be discussing/considering an additional config or control for this "default alignment" idea.
We REALLY appreciate your first PR, and despite closing this one, hope you continue to stay engaged with the community and keep making Superset better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org