You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2023/04/20 09:10:50 UTC

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #903: OAK-10196: switch oak-store-document to shaded guava

reschke commented on code in PR #903:
URL: https://github.com/apache/jackrabbit-oak/pull/903#discussion_r1172305520


##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/CacheInvalidationIT.java:
##########
@@ -39,7 +39,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static com.google.common.collect.Iterables.*;
+import static org.apache.jackrabbit.guava.common.collect.Iterables.*;

Review Comment:
   No. I'm not going to make any edits that will make the change bigger than necessary.
   
   I agree that wildcard imports are bad, but if we want to change them, that should be done as part of a separate issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org