You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2021/03/11 13:29:32 UTC
[GitHub] [bahir-flink] cheegoday opened a new pull request #112: 1. update flink version to 1.11.3
cheegoday opened a new pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112
2. fix netty connector unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday commented on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday commented on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-787416374
1. unit test will go wrong without dependencies below, so i add those dependencies to pom.xml of flink-netty-connector
```xml
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-clients_${scala.binary.version}</artifactId>
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
```
2. update flink version to 1.11.3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday commented on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday commented on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-787691505
@lresende hi, please review my PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-796713002
Thanks @cheegoday for the contribution :)
Could you change travis file to use the same flink version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe merged pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
eskabetxe merged pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday commented on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday commented on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-796734921
> Thanks @cheegoday for the contribution :)
>
> Could you change travis file to use the same flink version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-796919688
@cheegoday merged, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday closed pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday closed pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday closed pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday closed pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] cheegoday edited a comment on pull request #112: 1. update flink version to 1.11.3
Posted by GitBox <gi...@apache.org>.
cheegoday edited a comment on pull request #112:
URL: https://github.com/apache/bahir-flink/pull/112#issuecomment-796734921
@eskabetxe done, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org