You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li <li...@cloudera.com> on 2017/09/01 22:19:28 UTC

Review Request 62043: SENTRY-1914: Update field size in Sentry to Match Hive definition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62043/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Brian Towles, Sergio Pena, and Vamsee Yarlagadda.


Repository: sentry


Description
-------

Update sentry field size to match what's used in Hive. So sentry can persist the fields from hive successfully.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 734ea7f 
  sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.mysql.sql PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.oracle.sql PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.postgres.sql PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql 7475a5d 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 20c4cd9 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql 794ff17 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-2.0.0.sql b6d9d05 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-2.0.0.sql bf4754f 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-2.0.0.sql 6f4c606 


Diff: https://reviews.apache.org/r/62043/diff/1/


Testing
-------

unit tests
run update test for mysql and postgres


Thanks,

Na Li


Re: Review Request 62043: SENTRY-1914: Update field size in Sentry to Match Hive definition

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62043/#review184840
-----------------------------------------------------------



The SQL files for derby and DB2 have 4000 characters long. Should we update them too?

- Sergio Pena


On Sept. 1, 2017, 10:19 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62043/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 10:19 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Update sentry field size to match what's used in Hive. So sentry can persist the fields from hive successfully.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 734ea7f 
>   sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.mysql.sql PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.oracle.sql PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-1894.postgres.sql PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql 7475a5d 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 20c4cd9 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql 794ff17 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-2.0.0.sql b6d9d05 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-2.0.0.sql bf4754f 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-2.0.0.sql 6f4c606 
> 
> 
> Diff: https://reviews.apache.org/r/62043/diff/1/
> 
> 
> Testing
> -------
> 
> unit tests
> run update test for mysql and postgres
> 
> 
> Thanks,
> 
> Na Li
> 
>