You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 01:49:33 UTC
[jira] [Created] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
---------------------------------------------------------------------------------------
Key: HBASE-4710
URL: https://issues.apache.org/jira/browse/HBASE-4710
Project: HBase
Issue Type: Bug
Components: coprocessors
Affects Versions: 0.92.0, 0.94.0
Reporter: Gary Helmling
While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140947#comment-13140947 ]
stack commented on HBASE-4710:
------------------------------
+1 on patch.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141399#comment-13141399 ]
Andrew Purtell commented on HBASE-4710:
---------------------------------------
The test failures are unrelated. +1 on commit.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140909#comment-13140909 ]
Ted Yu commented on HBASE-4710:
-------------------------------
+1 on patch.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Gary Helmling (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4710:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Patch applied to 0.92 branch and trunk.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Gary Helmling (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4710:
---------------------------------
Attachment: HBASE-4710.patch
Simple patch adding the requisite constructor.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Gary Helmling (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4710:
---------------------------------
Fix Version/s: 0.92.0
Assignee: Gary Helmling
Status: Patch Available (was: Open)
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141543#comment-13141543 ]
Hudson commented on HBASE-4710:
-------------------------------
Integrated in HBase-0.92 #94 (See [https://builds.apache.org/job/HBase-0.92/94/])
Amend HBASE-4710 Fix CHANGES.txt addition
HBASE-4710 UnknownProtocolException should abort client retries as a DoNotRetryIOException
garyh :
Files :
* /hbase/branches/0.92/CHANGES.txt
garyh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141671#comment-13141671 ]
Hudson commented on HBASE-4710:
-------------------------------
Integrated in HBase-TRUNK #2396 (See [https://builds.apache.org/job/HBase-TRUNK/2396/])
HBASE-4710 UnknownProtocolException should abort client retries as a DoNotRetryIOException
garyh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4710) HBaseRPC$UnknownProtocolException
should abort any client retries in HConnectionManager
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140975#comment-13140975 ]
Hadoop QA commented on HBASE-4710:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501734/HBASE-4710.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -166 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestMasterFailover
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/118//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/118//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/118//console
This message is automatically generated.
> HBaseRPC$UnknownProtocolException should abort any client retries in HConnectionManager
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-4710
> URL: https://issues.apache.org/jira/browse/HBASE-4710
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.92.0
>
> Attachments: HBASE-4710.patch
>
>
> While {{HBaseRPC$UnknownProtocolException}} currently extends {{DoNotRetryIOException}}, it's still allowing retries of client RPCs when encountered in {{HConnectionManager.getRegionServerWithRetries()}}. It turns out that {{UnknownProtocolException}} is missing a public constructor taking a single {{String}} argument, which is required when unwrapping an {{IOException}} from a {{RemoteException}} in {{RemoteExceptionHandler.decodeRemoteException()}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira