[GitHub] [incubator-superset] lhsvobodaj commented on a change in pull request #8443: [contrib] Add Mapbox API key variable to docker compose file

[GitBox <gi...@apache.org>]

lhsvobodaj commented on a change in pull request #8443: [contrib] Add Mapbox API key variable to docker compose file
URL: https://github.com/apache/incubator-superset/pull/8443#discussion_r343488252
 
 

 ##########
 File path: contrib/docker/docker-compose.yml
 ##########
 @@ -42,6 +42,8 @@ services:
       dockerfile: contrib/docker/Dockerfile
     restart: unless-stopped
     environment:
+      # Add Mapxbox access token to correctly display deck.gl visualizations
+      #MAPBOX_API_KEY:
 
 Review comment:
   I wasn't aware of the support for environment variables in `docker-compose up`. Checking the docker folder, there is already a `.env` file there, and it is being tracked. That said, what do you think about keeping the `MAPBOX_API_KEY` as part of the `docker-compose` file, but modifying it to read the value from an environment variable? The result will look like this: 
   `MAPBOX_API_KEY: ${MAPBOX_API_KEY}`.
   
   In the README file, we add a note to inform the user about this option and how to set the variable:
   ```bash
   $ export MAPBOX_API_KEY=<your_mapbox_api_key>
   ```
   If you think it is better to have the `.env` file, another option could be specifying a "custom" environment file using the `env_file` option and add this file to the `.gitignore`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org