You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tonisojandu (via GitHub)" <gi...@apache.org> on 2023/10/02 12:30:19 UTC
[PR] [fix][client] Use byte schema for DLQ topic to avoid client side schema validation [pulsar]
tonisojandu opened a new pull request, #21294:
URL: https://github.com/apache/pulsar/pull/21294
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
Fixes #20635
### Motivation
When broker side schema validation is disabled and consumer receives an Avro message that has an incompatible schema then sending messages to DLQ fails due to a client side schema validation. This causes a fast loop that starts creating producers for DLQ topic, consumer gets stuck and explodes the number of producer metrics exposed from broker. [Example implementation of this issue](https://github.com/tonisojandu/pulsar-dlq-schema-issue-example).
### Modifications
By not inferring the DLQ producer schema from the consumer schema and just producing them as byte schema, this issue is fixed.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already mostly covered by existing tests, such as `org.apache.pulsar.client.impl.ConsumerImplTest`.
However, to cover this specific verification edge case `org.apache.pulsar.client.impl.ConsumerImpl` would need to refactored to expose `possibleSendToDeadLetterTopicMessages` for stubbing. Alternatively, a more complicated component test would be needed that would cover the complete `ConsumerImpl.messageReceived(CommandMessage cmdMessage, ByteBuf headersAndPayload, ClientCnx cnx). This would need to deal with encryption and compression. Did not find an example to base this potential test, so I am not sure what approach to take here.
Manually checked that the problem was solved in the constructed [example](https://github.com/tonisojandu/pulsar-dlq-schema-issue-example).
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/tonisojandu/pulsar
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Use byte schema for DLQ topic to avoid client side schema validation [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21294:
URL: https://github.com/apache/pulsar/pull/21294#issuecomment-1742929253
@tonisojandu Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Use byte schema for DLQ topic to avoid client side schema validation [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21294:
URL: https://github.com/apache/pulsar/pull/21294#issuecomment-1789933105
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org