You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "avelex (via GitHub)" <gi...@apache.org> on 2023/02/27 14:06:12 UTC

[GitHub] [flink-statefun] avelex opened a new pull request, #324: [fix] remove useless panics

avelex opened a new pull request, #324:
URL: https://github.com/apache/flink-statefun/pull/324

   ### The main goal of PR is to remove unnecessary panic where it should not be. 
   
   For example:
   ```
   msg, err := message.ToMessage()
   if err != nil {
   	panic(err)
   }
   ```
   
   So If such code is placed in a function which does not mean panic is present, unpleasant things may happen in the future. This is why panics have been removed from the `statefunContext` and `storage` module. 
   
   Also, the prefix Must has been added to functions that must be completed and cannot be avoided in the future
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] pocockn commented on pull request #324: [fix] remove useless panics

Posted by "pocockn (via GitHub)" <gi...@apache.org>.
pocockn commented on PR #324:
URL: https://github.com/apache/flink-statefun/pull/324#issuecomment-1459847396

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] avelex commented on pull request #324: [fix] remove useless panics

Posted by "avelex (via GitHub)" <gi...@apache.org>.
avelex commented on PR #324:
URL: https://github.com/apache/flink-statefun/pull/324#issuecomment-1468416542

   https://issues.apache.org/jira/browse/FLINK-31456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org