[GitHub] [iceberg] rdblue commented on a diff in pull request #4660: Core: Make snapshot summary return default values

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4660:
URL: https://github.com/apache/iceberg/pull/4660#discussion_r865152866


##########
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##########
@@ -354,4 +354,8 @@ private static void setIf(boolean expression, ImmutableMap.Builder<String, Strin
       builder.put(property, String.valueOf(value));
     }
   }
+
+  private static void set(ImmutableMap.Builder<String, String> builder, String property, Object value) {

Review Comment:
   What's the value of this method instead of `builder.set(property, value)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org